Skip to content

Conversation

@smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Nov 3, 2025

These are the changes which clang-tidy from LLVM 21.1.4 suggested. Mostly it suggest

  • make variable const &
  • reserving std::vector size before the for loop
  • added missing override

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49297/46658

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

+1

Size: This PR adds an extra 2092KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01728a/49210/summary.html
COMMIT: 6d0ce36
CMSSW: CMSSW_16_0_X_2025-11-03-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49297/49210/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4172318
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4172250
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 226 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

makortel commented Nov 4, 2025

On a cursory read looks ok to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment